Skip to content

gh-153309 Add HTTP QUERY method (RFC 10008) to http library - #153310

Closed
mbeijen wants to merge 7 commits into
python:mainfrom
mbeijen:httplib-query-method-rfc-10008
Closed

gh-153309 Add HTTP QUERY method (RFC 10008) to http library#153310
mbeijen wants to merge 7 commits into
python:mainfrom
mbeijen:httplib-query-method-rfc-10008

Conversation

@mbeijen

@mbeijen mbeijen commented Jul 8, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

RFC 10008: The HTTP QUERY Method is now a finalized RFC on the Standards track, and the method name has been added to the IANA registry

Add it to http library HTTPMethod enum, too

@read-the-docs-community

read-the-docs-community Bot commented Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33720199 | 📁 Comparing a39fa7e against main (aa533dc)

  🔍 Preview build  

85 files changed · + 3 added · ± 82 modified

+ Added

± Modified

@picnixz picnixz mentioned this pull request Jul 8, 2026
Open
picnixz
picnixz reviewed Jul 8, 2026
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need something like do_QUERY in HTTP client etcs? please also check if we need tests for that.

@mbeijen

mbeijen commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Don't we need something like do_QUERY in HTTP client etcs? please also check if we need tests for that.

We have these do_ methods in server, not in the client. And we do not need to add QUERY there, we have this code

cpython/Lib/http/server.py

Line 455 in 1051384

mname = 'do_' + self.command
that automatically parses the method names. We also do not have explicit methods there for do_DELETE and so on.

edvilme
edvilme reviewed Jul 8, 2026
View reviewed changes
Comment thread Lib/http/__init__.py Outdated
sobolevn
sobolevn reviewed Jul 8, 2026
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not a full review)

Comment thread Misc/NEWS.d/next/Library/2026-07-08-09-05-01.gh-issue-153309.g94LSO.rst Outdated
@picnixz

picnixz commented Jul 8, 2026

Copy link
Copy Markdown
Member

(I will do a review tomorrow while I am commuting)

@picnixz
picnixz self-requested a review July 8, 2026 20:33
picnixz
picnixz reviewed Jul 9, 2026
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good.

Comment thread Misc/NEWS.d/next/Library/2026-07-08-09-05-01.gh-issue-153309.g94LSO.rst Outdated
Comment thread Doc/library/http.client.rst
@mbeijen
mbeijen requested a review from AA-Turner as a code owner July 9, 2026 09:12
@mbeijen
mbeijen requested a review from picnixz July 10, 2026 18:52
@mbeijen
mbeijen requested review from edvilme and sobolevn July 23, 2026 06:43
@mbeijen

mbeijen commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

@picnixz you seem to be the most active reviewer on this PR, can you help me move this forward?

edvilme
edvilme reviewed Aug 4, 2026
View reviewed changes

@edvilme edvilme left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a Core Dev but left my little review. Additionally I would look into adding more tests that make sure the actual HTTP request gets created properly

Comment thread Lib/http/__init__.py

* RFC 9110: HTTP Semantics, obsoletes 7231, which obsoleted 2616
* RFC 5789: PATCH Method for HTTP
* RFC 10008: The HTTP QUERY Method

@edvilme edvilme Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change the wording so that it matches the previous statement?

Suggested change
* RFC 10008: The HTTP QUERY Method
* RFC 10008: QUERY Method for HTTP

@mbeijen mbeijen Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well now it matches RFC

edvilme
edvilme reviewed Aug 4, 2026
View reviewed changes

@edvilme edvilme left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: Duplicate comment, but can't remove

@python-cla-bot

python-cla-bot Bot commented Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@mbeijen
mbeijen force-pushed the httplib-query-method-rfc-10008 branch from 7029866 to c1fc922 Compare August 14, 2026 11:43
@mbeijen

mbeijen commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@StanFromIreland why did you close? I think I messed up because i wanted to merge origin/main into my tree and then I force pushed, is that a big nono? What should I do now, open a new PR and start again?

@StanFromIreland

StanFromIreland commented Aug 14, 2026

Copy link
Copy Markdown
Member

Open up a new PR, you've requested a review from many people who have now been automatically subscribed to this PR.

@mbeijen mbeijen mentioned this pull request Aug 14, 2026
Open
@mbeijen

mbeijen commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

Open up a new PR, you've requested a review from many people who have now been automatically subscribed to this PR.

Yeah I'm sorry, I messed up by rebasing in the wrong direction and this triggered a massive set of reviewers that got added because of CODEOWNERS :sad: sorry for the mess

@terryjreedy

terryjreedy commented Aug 14, 2026

Copy link
Copy Markdown
Member

merging main into PR branches is normal and should never cause an issue other than a merge conflict that really needs fixing. force-pushing on PR branches is seldom (never?) needed and not wanted and can cause the problem here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments
@picnixz picnixz picnixz left review comments
+1 more reviewer
@edvilme edvilme edvilme left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mbeijen @picnixz @StanFromIreland @terryjreedy @sobolevn @edvilme